-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference counting bug: tests are resulting in a bad reference count error #71
Comments
Just stumbled across this project and thought I would give this a try.
|
ah, i forgot that i left out that i compiled godot with
|
here is my output: Env:
$(MAKE) ci_gen_test_project_files:
$(MAKE) test:
|
There seems to be an issue in Godot itself: godotengine/godot#73554 |
@dennwc Nicely spotted .... Any thoughts on actions ? wait it out on their side ? |
README currently states that:
This note should probably be replaced with a reference to Godot issue instead. And it looks like it's not a blocker after all. |
If this is not a blocker, are the bindings as they are usable, unlike what is currently hinted by the readme? |
my original understanding of the issue was incorrect. but i have a massive PR that i'm going to merge in soon that fixes the needed changes to support
this will require using 4.2-dev5. i'l try to get my remaining changes merged in this by the weekend. |
Describe the bug
To Reproduce
Steps to reproduce the behavior:
dev_build
enabled:make test
Expected behavior
There shouldn't be a reference count error.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
The godot-go code currently doesn't do any of the reference counting it should be. this ticket is effectively the placeholder to get that implemented correctly and possibly with an idiomatic way of doing it the go way
The text was updated successfully, but these errors were encountered: