Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip downloading #36

Merged
merged 1 commit into from May 26, 2023
Merged

zip downloading #36

merged 1 commit into from May 26, 2023

Conversation

bend-n
Copy link
Member

@bend-n bend-n commented May 25, 2023

implements #33

@bend-n bend-n force-pushed the zip branch 2 times, most recently from d96e561 to 8637617 Compare May 26, 2023 02:40
@bend-n bend-n marked this pull request as ready for review May 26, 2023 02:41
@bend-n bend-n linked an issue May 26, 2023 that may be closed by this pull request
has terrible api
@bend-n bend-n merged commit dcc6b4e into main May 26, 2023
1 check passed
@bend-n bend-n deleted the zip branch May 26, 2023 02:45
@razcore-rad
Copy link

Thanks for looking into this!

@razcore-rad
Copy link

Quick question: this only works with tarballs/zips etc? But not repos like https://github.com/bend-n/splitter.git with version like main/branch/tag, correct?

So for example something like:

packages: {
  "https://github.com/bend-n/splitter.git": main
}

Or is there a specific syntax that works this way? I checked the godot.package file from the commit.

@bend-n
Copy link
Member Author

bend-n commented May 26, 2023

this pr doesnt add .git, correct.
if you want to specify the branch or something you can do https://github.com/bend-n/splitter/archive/refs/heads/ref.zip.

@razcore-rad
Copy link

That's what I thought, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing from git
2 participants