Implement PartialEq for Packed*Array and Eq where appropriate

[ttencate]

See #33.

[Bromeon]

Thanks, looks nice! 👍

The named keys for the macro are mostly for expressivity reasons, or is it needed for parsing disambiguation? Arguably some parts are less readable now, because the symbols are no longer aligned. On the other hand, it's nice ensure it's at the right argument position.

-    i64,
-    i64,
-    packed_int64_array_construct_default,
-    packed_int64_array_construct_copy,
-    packed_int64_array_from_array,
-    packed_int64_array_destroy,
-    packed_int64_array_operator_index,
-    packed_int64_array_operator_index_const,
+    argument_type: i64,
+    return_type: i64,
+    from_array: packed_int64_array_from_array,
+    operator_index: packed_int64_array_operator_index,
+    operator_index_const: packed_int64_array_operator_index_const,
+    trait_impls: {
+        Default => packed_int64_array_construct_default;
+        Clone => packed_int64_array_construct_copy;
+        Drop => packed_int64_array_destroy;
+        Eq => packed_int64_array_operator_equal;
+    },

Anyway, that's bikeshedding, no need to fix 🙂 In general, I wouldn't spend too much time on making this macro look nice, as we're going to rewrite quite a bit once the codegen provides genericity over packed arrays.

[Bromeon]

bors try

[bors]

try

Build succeeded:

• full-ci

[ttencate]

The named keys for the macro are mostly for expressivity reasons, or is it needed for parsing disambiguation?

Readability. The argument list got horribly long and it was hard to tell what each argument did. Too bad about the vertical alignment 🤷

[Bromeon]

Fair enough, thanks again! 🙂

bors r+

[bors]

Build succeeded:

• full-ci