#[export] infer VariantType
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
Bromeon
reviewed
Mar 6, 2023
Comment on lines
+42
to
+46
| impl<T: VariantMetadata> VariantMetadata for Option<T> { | ||
| fn variant_type() -> VariantType { | ||
| T::variant_type() | ||
| } | ||
| } |
There was a problem hiding this comment.
We have to statically (at compile time) determine a variant type for a given Rust type.
Option::None however would typically correspond to NIL -- may that cause problems?
There was a problem hiding this comment.
As far as I can see it, every time you recive a Variant it could be NIL even if you have declared another type.
For example if you reset a Property in the Inspector per default it gets set to NIL.
mio991
force-pushed
the
faeture/export-infer-variant-type
branch
from
c2c9ca0
to
67a68e4
Compare
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the explicit
VariantTypedeclaration and replaced it with the ability to infer the same.Also added an implementation for
VariantMetadataforOptionnot sure if this is good but it was necessary.