Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Export trait to use in autogenerated getters #198

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add an Export trait to use in autogenerated getters #198

merged 1 commit into from
Mar 22, 2023

Conversation

ttencate
Copy link
Contributor

Fixes #197.

Note that some types are still not supported, since they're not implemented yet in gdext: Aabb, Plane, Rect2 and Rect2i.

Signal and Callable don't implement Export either. Probably it makes no sense for Signal, and should eventually be supported for Callable.

@ttencate ttencate mentioned this pull request Mar 22, 2023
Closed
@Bromeon
Copy link
Member

Bromeon commented Mar 22, 2023

Thank you! Can we blanket-impl Export for Share?

@ttencate
Copy link
Contributor Author

Probably. Should we? I don't know how Signal is implemented and if it will impl Share, but we wouldn't want to accidentally impl Export for it.

@Bromeon
Copy link
Member

Bromeon commented Mar 22, 2023

Fair point -- it's not much duplication for now, so we can keep it as is.

bors r+

@Bromeon Bromeon added feature Adds functionality to the library c: register Register classes, functions and other symbols to GDScript labels Mar 22, 2023
@bors
Copy link
Contributor

bors bot commented Mar 22, 2023

Build succeeded:

  • full-ci

@bors bors bot merged commit eb30a8b into godot-rust:master Mar 22, 2023
@lilizoey lilizoey mentioned this pull request Apr 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: register Register classes, functions and other symbols to GDScript feature Adds functionality to the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[export] fails to compile for Gd types
2 participants
@ttencate @Bromeon