Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to library for macos in README #21

Merged
merged 1 commit into from Nov 20, 2022
Merged

Add link to library for macos in README #21

merged 1 commit into from Nov 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2022

No description provided.

Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a small remark.

ReadMe.md Outdated
Comment on lines 98 to 99
[Discord]: https://discord.gg/aKUCJ8rJsc No newline at end of file
[Discord]: https://discord.gg/aKUCJ8rJsc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed here? 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of a new line, I think. I edited it within github so it's probably the github editor formatting the text.

@Bromeon Bromeon added the documentation Improvements or additions to documentation label Nov 16, 2022
@Bromeon
Copy link
Member

Bromeon commented Nov 16, 2022

Since macOS + ARM is quite common setup (M1), would it make sense to add another config for that as well?

See https://docs.godotengine.org/en/latest/tutorials/export/feature_tags.html#default-features

@ghost
Copy link
Author

ghost commented Nov 16, 2022

Yes the apple silicon computers are arm64.

@Bromeon
Copy link
Member

Bromeon commented Nov 16, 2022

My point is, does the macos.64 work for those, or do we need macos.arm64?
In my link it says:

Running on a 64-bit build (any architecture)

so in theory it should be enough to have .64. So maybe let's leave this PR as-is.

@ghost
Copy link
Author

ghost commented Nov 17, 2022

I agree. I use an x86 macbook so i cannot confirm for certainty, but macos.64 should work for arm64 too. At least that's what the documentation suggests.

@Bromeon Bromeon merged commit 5a8a000 into godot-rust:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant