Track ptrcall/varcall in tests; smaller improvements #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
the
quality-of-life
|
Testing closing... |
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-658 |
Changes: * declare call_ctx only once * declare Sig type only once * avoid unnecessary blocks arounds ptrcall/varcall fns (keep for virtual fn) * minor syntactical simplifications
Bromeon
changed the title
|
macOS unit-test jobs have been unstable before, although I haven't encountered this problem earlier 🤔 let's see if the issue persists... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that inbound GDScript -> Rust
#[func]calls are using the expected calling convention (ptrcallorvarcall).There are some exceptions due to incomplete implementation in Godot:
ptrcallconvention godotengine/godot#91282VariantparametersAlso renames the
tracefeature todebug-log, fixes some#[func]FFI registrations, and fixes a doc CI issue.