Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling updates #1074

Merged
merged 9 commits into from
Apr 6, 2024
Merged

Tooling updates #1074

merged 9 commits into from
Apr 6, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Apr 1, 2024

Make CI work again, and modernize things a bit.

Changes:

  • Address clippy lints (stable + some nightly), including the one suggested by y21 to fix the ICE
  • Replace obsolete actions-rs toolchain with direct rustup calls
  • Update actions/checkout, actions/cache
  • Update cargo-dinghy, cargo-deny, cargo-machete
  • Bump MSRV from 1.67 to 1.70
  • Remove serde_yaml from tests (no longer maintained)

Closes #1073.

@Bromeon Bromeon added c: ci Component: CI and automation quality-of-life No new functionality, but improves ergonomics/internals labels Apr 1, 2024
@Bromeon
Copy link
Member Author

Bromeon commented Apr 1, 2024

Ugh... an ICE in the futures crate, see CI run.

Unfortunately I don't have the time to debug/minimize that right now 😕

@chitoyuu
Copy link
Contributor

chitoyuu commented Apr 2, 2024

Ugh. I think it's the same ICE that I've ran into earlier here. Haven't had the time to debug it properly yet either. I guess we can also just report the issue immediately. It's more work for upstream but I'd imagine them to be much better at debugging ICEs than either of us, and some report is better than nothing.

@Bromeon
Copy link
Member Author

Bromeon commented Apr 2, 2024

Agree. Do you have time to report it, or should I?

@chitoyuu
Copy link
Contributor

chitoyuu commented Apr 2, 2024

I've created rust-lang/rust-clippy#12616.

@Bromeon
Copy link
Member Author

Bromeon commented Apr 2, 2024

That was fixed insanely fast 👀

I guess we have to wait until next stable, unless we change CI config?

@chitoyuu
Copy link
Contributor

chitoyuu commented Apr 3, 2024

Probably. I don't think waiting for a stable release should be much of a problem for this repo, vs changing the CI config now only to have to change it back in a few more weeks. It would be productive to check locally with nightly after the changes get released in one of course, just to make sure that there isn't anything else the MCVE failed to capture.

@y21
Copy link

y21 commented Apr 3, 2024

(coming from the clippy issue since I saw it linked)
If this ICE blocks you and you want to "work around" it, you can also just fix the pedantic warning that would have been emitted if clippy didn't die on that fn call, by using .cast::<sys::godot_object>() instead of an as cast here

let ptr = NonNull::new(ctor() as *mut sys::godot_object)?;

fwiw, I did verify that clippy no longer ICEs on this crate with the fix applied

warning: `gdnative-core` (lib) generated 27 warnings
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.56s

ICE was fixed in the meantime, this addresses the problem until next stable release.
@Bromeon Bromeon added this pull request to the merge queue Apr 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2024
@Bromeon
Copy link
Member Author

Bromeon commented Apr 6, 2024

Thanks a lot @y21, also for the very fast clippy fix. It's really appreciated! ❤️

@Bromeon Bromeon added this pull request to the merge queue Apr 6, 2024
@Bromeon
Copy link
Member Author

Bromeon commented Apr 6, 2024

@chitoyuu Addressed several things to make CI green again -- see initial message for details.

Nightly clippy has a lot of warnings that would take significant maintenance effort (moving around imports, refactoring ToString, etc). I'm not sure that has any benefit for this library, so I don't plan on spending more time on those. We can maybe selectively disable some, or opt out of nightly altogether, but that can be another discussion 🙂 some less controversial ones are fixed here, too.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2024
The macro parse_quote_spanned!() has been introduced there.
@Bromeon Bromeon added this pull request to the merge queue Apr 6, 2024
Merged via the queue into master with commit 0763d73 Apr 6, 2024
7 checks passed
@Bromeon Bromeon deleted the qol/tools branch April 6, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: ci Component: CI and automation quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serde_yaml end of life
3 participants