Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot_init may not find some symbols #954

Merged
merged 1 commit into from Oct 2, 2022

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Oct 2, 2022

This fixes an issue for users without use gdnative::prelude::*, which could run into an error regarding symbols not found (e.g. Variant).

bors try

@Bromeon Bromeon added the bug label Oct 2, 2022
@Bromeon Bromeon added this to the v0.11.x milestone Oct 2, 2022
bors bot added a commit that referenced this pull request Oct 2, 2022
This fixes an issue for users without `use gdnative::prelude::*`, which could run into
an error regarding symbols not found (e.g. Variant).
@Bromeon Bromeon force-pushed the bugfix/version-check-import branch from 213d801 to 443901d Compare October 2, 2022 11:05
@Bromeon
Copy link
Member Author

Bromeon commented Oct 2, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

try

Build failed:

@Bromeon
Copy link
Member Author

Bromeon commented Oct 2, 2022

bors try-
bors try

bors bot added a commit that referenced this pull request Oct 2, 2022
@Bromeon
Copy link
Member Author

Bromeon commented Oct 2, 2022

bors r+

@Bromeon Bromeon changed the title Import symbols used in version check (through macro) godot_init may not find some symbols Oct 2, 2022
@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

try

Build succeeded:

@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

Build succeeded:

@bors bors bot merged commit 9ca2b40 into godot-rust:master Oct 2, 2022
@Bromeon Bromeon deleted the bugfix/version-check-import branch October 2, 2022 11:20
@chitoyuu chitoyuu modified the milestones: v0.11.x, v0.11.1 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants