Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The editorconfig settings are overridden #48

Open
1 of 2 tasks
oeN opened this issue Apr 21, 2020 · 4 comments
Open
1 of 2 tasks

The editorconfig settings are overridden #48

oeN opened this issue Apr 21, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@oeN
Copy link

oeN commented Apr 21, 2020

I'm submitting a...

  • Bug report.
  • Feature request.

Bug report

I have the editorconfig package enabled and an .editorconfig file:

root = true

[*]
indent_size = 2
indent_style = tab

[*.yml]
indent_style = space
indent_size = 2

I'm using Doom Emacs :)

What is the current behavior?
When editing a gdscript file indenting from the NORMAL mode with Shift+>+> works correctly but from the INSERT mode if I press tab the indent size used is 4.

If I change the indent size to 2 with gdscript-indent-offset it works as expected

What is the expected behavior?
Let the editorconfig preference overrides the indent size configured for gdscript-mode

Tell us the steps to reproduce the bug, and if possible share a minimal demo of the problem.

  1. Enable the editoconfig package
  2. Create an .editorconfig file like the one above (or with different indent size between editor config and gdscript-mode)
  3. Try to indent a line

Thanks!

@NathanLovato NathanLovato added the bug Something isn't working label Apr 23, 2020
@NathanLovato
Copy link
Collaborator

Thanks for the report. That's strange to me, gdscript-indent-offset shouldn't affect anything other than .gd files.

@oeN
Copy link
Author

oeN commented Apr 24, 2020

Thanks for the reply :)
Sorry, I didn't explain well enough, the problem is on the .gd files this problem doesn't affect other file types, for example on a .py file the indentation is consistent between the TAB and the >+> of evil

@jcs090218
Copy link
Collaborator

I think the issue is from Emacs editorconfig. I've opened an PR in editorconfig/editorconfig-emacs#300 to resolve this issue.

@jcs090218
Copy link
Collaborator

@oeN Now the editorconfig/editorconfig-emacs#300 PR has merged, can you download the latest version and try to see if it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants