Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Add colors to Scene tab to improve readability (complements Inspector color variation for nested sections) #3014

Closed
viksl opened this issue Jul 19, 2021 · 3 comments

Comments

@viksl
Copy link

viksl commented Jul 19, 2021

Describe the project you are working on

This feature improves Editor's user experience not a particular game.

Describe the problem or limitation you are having in your project

Currently the Scene tab uses one color line for all it's nodes, this is simple in case of a one layer or two nodes layer setup but with more nodes added the readibility decreases sigfinicantly especially if the list is longer but even with just 2-3 layers of nodes, example:

| NodeA
| -> NodeB
|- -> NodeC

Describe the feature / enhancement and how it helps to overcome the problem or limitation

In the image below you can see how adding color variations can hugely improve how the scene's scheme can be read easier.

In this example I've chosen the colors pretty much randomly only making sure no 3 successive layers have the same or similar color to demonstrate the proposal.

Godot-Scene-Manager-Proposal

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

This would have to be an automatic feature, since similar system is already in place for Inspector, perhaps it could be extended to the Scene tab too?

Unfortunately, I do not have better knowledge of godot to suggest a particular implementation in the system.

If this enhancement will not be used often, can it be worked around with a few lines of script?

I don't know if this can be dealt with without making changes to godot's core.

Is there a reason why this should be core and not an add-on in the asset library?

I don't know if this can be dealt with without making changes to godot's core.

@timothyqiu
Copy link
Member

This reminds me of rainbow brackets :)

It looks a bit busy in the mockup, maybe some less saturated color might look better.

@viksl
Copy link
Author

viksl commented Jul 19, 2021

This reminds me of rainbow brackets :)

It looks a bit busy in the mockup, maybe some less saturated color might look better.

Yeah I picked higher contrast colors, when it comes to Inspector the colors and their intensity actually changes based on the theme and how you set it up so I'd assume that could help with this too.

@YuriSizov
Copy link
Contributor

YuriSizov commented Jul 19, 2021

This is a duplicate of #2654. After testing out colors were deemed to be too distracting, so saturation and thickness were used instead: godotengine/godot#48546.

Here's an example of how it looks in master:

image


Edit: I realize that the proposal I've linked is about selection and yours is about constantly having colors. Something like this would result in a very complicated Tree rendering logic for likely not much gain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants