This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
fix: declare StorageKey as HexNumber type #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RetricSu
reviewed
Aug 29, 2022
RetricSu
approved these changes
Aug 29, 2022
Flouse
approved these changes
Sep 1, 2022
|
Shall we lock reusable-integration-test-v1.yml@904f4aae08d0c6b3a4624a6b9e4fbba4ac2719f9 to fix integration-test temporally? |
can rebase solve the CI problem? |
keroro520
force-pushed
the
fix-storage-index-type
branch
from
5759d1c
to
92845a0
Compare
I am not sure about it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #507
Cause: EIP-1474 declares the storage position as
Quantitytype but we declare it asHexString.