Support non EIP-155 tx #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secp256k1Tron and Secp256k1 signing are never supported in the testnet and the mainnet. So we remove the unused implementation.
Date: Wed Aug 3 22:32:18 2022 +0800
On branch support-non-eip155-tx
Changes to be committed:
modified: crates/block-producer/src/runner.rs
modified: crates/generator/src/account_lock_manage/secp256k1.rs
modified: crates/replay-chain/src/setup.rs
modified: crates/tests/src/tests/chain.rs
modified: crates/types/src/core.rs
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@classicalliu Can you modify godwoken-indexer and web3 server to support non-EIP-155 txs |
zeroqn
previously approved these changes
Aug 9, 2022
Running integration testWorkflow Run Id: 2832571902 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
This was referenced Aug 15, 2022
classicalliu
approved these changes
Aug 15, 2022
zeroqn
approved these changes
Aug 15, 2022
RetricSu
approved these changes
Aug 17, 2022
magicalne
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #775
To support EIP-155, Godwoken accepts
chain_id = 0l2 txs now, we assume the tx is non-EIP-155 tx whenchain_id=0.Since we reuse the
chain_idfield, it implies if we deploy another Godwoken instance withchain_id=0, then we can't send a valid EIP-155 transaction on that chain since Godwoken assumeschain_id=0txs are non-EIP-155.This PR also removes the unused Secp256K1 and Secp256K1Tron implementation.