Add rate limit error handling #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
There's already some sort of built-in progress backup using the If there's a 429 before the .cache is saved, we save the url with status "Error" (or maybe "RateLimited"?), but we don't exit the script. After the .cache is saved, when we're doing the indexing process, if there's a 429 we notify the user and exit cleanly instead of treating it as an error. What you think? |
|
Yes it can be good I'll try to do it like that |
|
@goenning it might be better now what do you think ? |
Code.mp4 |
|
Looks great, thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did I change?
I've added a custom error message and a process stop when a 429 error occurs.
Why did I change it?
To partially fix #8, but as we discussed (#8 (comment)), we'll also need to add a progress backup in a future pull request.