Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clipboardy #17

Closed
wants to merge 1 commit into from
Closed

Use clipboardy #17

wants to merge 1 commit into from

Conversation

floatdrop
Copy link

Closes #13

@TonySFU
Copy link

TonySFU commented May 12, 2017

Can you add this line under your pull requests? It solve this problem.
process.env["LC_CTYPE"] = process.env.LC_CTYPE || "UTF-8";

for more information microsoft/vscode#26502 (comment)

Copy link

@TonySFU TonySFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this code on the top of extension.js file will solve this problem.

process.env["LC_CTYPE"] = process.env.LC_CTYPE || "UTF-8";

@floatdrop
Copy link
Author

We will add it in sindresorhus/clipboardy#15 (comment) - looks like it should be there.

@floatdrop
Copy link
Author

@TonySFU this is fixed in clipboardy@1.1.2.

package.json Outdated
@@ -117,7 +117,7 @@
},
"dependencies": {
"argparse": "^1.0.9",
"copy-paste": "^1.3.0",
"clipboardy": "^1.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump it to 1.1.2, just to make sure it's never deduped to a lower version.

@goessner
Copy link
Owner

Thanks a lot for your help. I reused your modifications with some other bug fixes directly in the source.

@goessner goessner closed this May 14, 2017
@TonySFU
Copy link

TonySFU commented May 14, 2017

Did you test on windows platform? Clip function seems not working on newest version mdmath.

@floatdrop
Copy link
Author

@TonySFU we have tests on Windows platform.

@TonySFU
Copy link

TonySFU commented May 14, 2017

That's weird, the Clip Markdown+Math to HTML function not return any result on my windows 10 pc. Works great on the macbook.
I download directly from vscode marketplace

@goessner
Copy link
Owner

goessner commented May 15, 2017

Hmm ... I did test it on windows 10 .. it worked.

Now I have tested it again .. and even included your snippet

一级标题

  • HI
  • HIHI

二级标题

三级标题

this also works (copying from clipboard to html document).

I will now delete my mdmath extension and reinstall it again from marketplace.

...

which works as before ... hmm.

@goessner
Copy link
Owner

I obviously forgot some entries in the (flat) dependencies list in package.json.

Hopefully this was it ?! (1.2.9)

@TonySFU
Copy link

TonySFU commented May 15, 2017

I found this problem only happen when markdown file is large.
#19

@goessner
Copy link
Owner

@sindresorhus, @TonySFU: Isn't new copy-text-to-clipboard a better alternative to clipboardy now ?

@TonySFU
Copy link

TonySFU commented May 24, 2017

it related on clipboardy, and this one just work in browsers. For now it works great on macOS. When markdown file is large, clipboardy will hit limit on arguments length in Windows. @floatdrop try to fix it #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants