adding an editorconfig that seems to match the project style #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
reviewed
Oct 25, 2017
| indent_size = 2 | ||
|
|
||
| [composer.json] | ||
| indent_style = tab |
There was a problem hiding this comment.
what if we change composer indent by spaces?
There was a problem hiding this comment.
I think I did that on the static-analysis branch.
I could change it to spaces on this branch if you'd prefer ?
|
I like it anyway. |
3 tasks
SignpostMarv
added a commit
to SignpostMarv/xsd-reader
that referenced
this pull request
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insert_final_newline = falseseems to be ignored by the editorconfig plugin for Atom, but other than that this seems to match what's on master.