Allow phpunit 9 & update doctrine/inflect to ^2.0 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks a lot for this 🎉 |
|
@goetas You're welcome, and thank you for this package :)! Can you also make a new tag for this? (I think we need to tag a 1.0.0 version because of dropped support for php 7.1) I also noticed that CI isn't working properly if I'm correct, if you want to switch over to Github actions, I can make a PR with a script if you'd like |
|
having github actions would be great! thanks a lot I will create a new tag, dropping dependencies is not a BC break, so a usual increment is ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our company wants to upgrade to Laravel 9, but certain dependencies need to be allowed.
Doctrine 1.4 and 2.0 are not compatible with each other, so I set the minimum version to ^2.0. This will automatically make the minimum php version required to 7.2. I went through the code and fixed the breaking changes.
We also need to allow php-unit 9, but this is not compatible with phpunit 5 and is from version 6 or higher. Also fixed all breaking changes.
Tests succeed: DanielGSoftware#1