Added symfony validator feature #2

goetas · 2016-10-31T16:46:31Z

No description provided.

goetas · 2016-11-01T09:04:55Z

src/Jms/YamlValidatorConverter.php

            }

-            if ($rules) {
+            if (!!count($rules)) {


please use a more intuitive boolean. !==0 is more understandable

Applied better codding. See 3151dcb

goetas · 2016-11-01T09:17:13Z

src/Jms/YamlValidatorConverter.php

+                }
+            }
+
+            if (!!count($rules)) {


please use !==0 or >0

Applied better codding. See 3151dcb

goetas · 2016-11-01T09:18:45Z

src/Jms/YamlValidatorConverter.php

+        }
+    }
+
+    protected function visitSimpleType(&$class, &$data, SimpleType $type, $name)


we can have also arrays of objects, not just primitives, they have to be validated too.

essentially each property needs the rule Valid to apply recursive validation.

Implemented feature to apply these rules. See c1699dc

goetas · 2016-11-01T09:19:05Z

tests/Converter/JMS/Xsd2JmsBase.php

@@ -38,7 +38,7 @@ protected function getClasses($xml)
    public function getBaseTypeConversions()
    {
        return [
-            ['xs:dateTime', 'DateTime'],
+            ['xs:dateTime', 'GoetasWebservices\\Xsd\\XsdToPhp\\XMLSchema\\DateTime'],


This method is used as dataProvider in testElementOfBaseType. Adjusted to fill param $phpName with GoetasWebservices\\Xsd\\XsdToPhp\\XMLSchema\\DateTime value. See 32dc6ff

goetas · 2016-11-01T09:20:33Z

tests/Converter/Validator/Xsd2ValidatorBase.php

+use GoetasWebservices\Xsd\XsdToPhp\Naming\ShortNamingStrategy;
+use GoetasWebservices\XML\XSDReader\SchemaReader;
+
+abstract class Xsd2ValidatorBase extends \PHPUnit_Framework_TestCase


currently there is only one class that inherits from this (Xsd2ValidatorTest) isn't this premature architecture?

Fixed. See baff9be

goetas · 2016-11-01T09:22:07Z

tests/Converter/Validator/Xsd2ValidatorTest.php

+             <xs:schema targetNamespace="http://www.example.com" xmlns:xs="http://www.w3.org/2001/XMLSchema"  xmlns:ex="http://www.example.com">
+                <xs:complexType name="complexType-1">
+                    <xs:sequence>
+                        <xs:element name="column1">


this test is good, I will add another test, having <xs:element name="column1" maxOccours="unbounded">

Created some tests in separate cases. See f42fe40

goetas · 2016-11-01T09:22:20Z

tests/Converter/Validator/Xsd2ValidatorTest.php

+    {
+        $xml = "
+             <xs:schema targetNamespace=\"http://www.example.com\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\">
+                <xs:element name=\"element-one\">


this test is good, I will add another test, having <xs:element name="element-one" maxOccours="unbounded">

Created some tests in separate cases. See f42fe40

goetas · 2016-11-01T09:23:36Z

tests/Converter/Validator/Xsd2ValidatorTest.php

+                            $ymlValidations,
+                            [
+                                [
+                                    'NotBlank' => null


pay attention, there is a subtle difference between NotBlank and NotNull.

In almost all the cases you should use not null probably

Based NotBlank doc implement not equal to a blank string and also not equal to null. It's great for me. What do you think?

in xml, a node that says:

minOccours=1, regex="[a-z]"

and empty string is a valid value :)

Perfect. You convinced me, :)

goetas · 2016-11-01T09:24:01Z

tests/Validator/ValidatorTest.php

+    public function setUp()
+    {
+        $loader = new ClassLoader();
+        $loader->addPsr4("OTA\\", "/home/goetas/projects/goetas-webservices-xsd2php/ota/php");


this are just example paths.. they have to be configured.

goetas · 2016-11-01T09:25:09Z

src/Jms/YamlValidatorConverter.php

+                        'Count' => ['min' => 1]
+                    ];
+                }
+                $property["validator"][] = [


probably this is not necessary (or is an constraint that we do not know yet if apply or not)

At first is necessary for simple type/native type for indicate if required or not.

…s array. Fix some bugs for visit array elements.

davidsonalencar · 2016-11-01T19:27:11Z

Reading extended elements still need to be implemented.

…ot use 'validator' item. Fix some bugs.

…te classes with inherit.

goetas · 2019-01-20T18:01:44Z

If somebody is interested in sponsoring this feature I can continue to work on it.

Pricing can be agreed (compatible with west-european hourly rates).

goetas · 2019-04-27T14:06:13Z

After a lot of work, this is almost done.
Validating the objects before or after xsd serialization/deserialization now is possible using the symfony/validator generated metadata!

Only a bit of documentation in missing.

goetas · 2019-04-27T14:16:29Z

Syntax should be:

<?php

use Symfony\Component\Validator\Validation;

// get the validator
$builder = Validation::createValidatorBuilder();
foreach (glob('soap/validation/*.yml') as $file) {
    $builder->addYamlMapping($file);
}
$validator =  $builder->getValidator();

// validate $object
$violations = $validator->validate($object, null, ['xsd_rules']);

davidsonalencar and others added 11 commits October 28, 2016 19:04

Identified mode to add validator in YAML.

22f507e

Added symfony validator.

1a56035

Created validator by YML

d7691a6

Fixed validation in array items.

c91fc5e

Fixed some bugs

9d72116

Fixed some bugs

f99c524

Created tests to measure the conversion of validations.

ab74de0

revert changes and make visitSimpleType protected

6f562e8

added separate validation converter

c6c6d48

add the validation converter via DI and remove old validation class

68867d6

add validation tests

abfaf3e

goetas added the enhancement label Oct 31, 2016

goetas and others added 4 commits October 31, 2016 17:53

do not skip rules

7e0d81a

added array rule

ea83802

Fix bug. Last rules are lost.

aeb9eb5

Implement some test convert validations

b33a79e

goetas commented Nov 1, 2016

View reviewed changes

goetas changed the title ~~Added symfony validator feature~~ [WIP] Added symfony validator feature Nov 1, 2016

davidsonalencar added 5 commits November 1, 2016 10:22

Better use the dataProvider getBaseTypeConversions

32dc6ff

Fix bug. Wasn't accumulating validators when call loadValidatorElement.

3151dcb

Fixed premature architecture.

baff9be

Implemented rule Valid for objects and rule All with Valid for object…

c1699dc

…s array. Fix some bugs for visit array elements.

Created some tests to ensure validator converter.

f42fe40

davidsonalencar and others added 6 commits November 2, 2016 01:00

Fix signature override

4785382

Changed visibility to be used some methods in YamlValidatorConverter.

5afae6c

Added feature to load from extensions and attributes. Clean code to n…

5d13020

…ot use 'validator' item. Fix some bugs.

Created more tests to validate extensions and attributes elements.

92fe474

Created pattern of the Symfony Validator to be used in other tests.

1554db4

Resolved conflits.

43d7e2f

davidsonalencar and others added 4 commits November 3, 2016 23:23

Fix signature override

5506be6

Upgraded xsd-reader's version.

88220ab

Changed properties from PRIVATE to PROTECTED to insure Symfony valida…

29f99f8

…te classes with inherit.

Removed unnecessary hierarchy of rules Valid in All.

2299a8f

goetas mentioned this pull request Feb 22, 2017

maxOccurs and minOccurs in Roadmap? #19

Open

goetas added the help wanted label Feb 22, 2017

goetas mentioned this pull request May 24, 2017

Problem creating sample XML using generated PHP classes and JMS Serializer metadata #34

Closed

nerijusza mentioned this pull request Aug 24, 2017

IATA NDC schemas 16.2 not working v2 #40

Closed

goetas mentioned this pull request Nov 29, 2017

Choise tag in ComplexType goetas-webservices/xsd-reader#5

Closed

goetas mentioned this pull request Oct 28, 2018

Convert minOccurs and restriction into Doctrine annotation Require and Enum #70

Closed

goetas added 6 commits April 26, 2019 10:20

Merge remote-tracking branch 'origin/master' into validator

6283027

xsd2php symfony validator

5828f8c

xsd2php symfony validator

d949339

xsd2php symfony validator

4b5155c

xsd2php symfony validator

fd88c82

fix tests

f312f67

goetas changed the title ~~[WIP] Added symfony validator feature~~ Added symfony validator feature Apr 27, 2019

goetas merged commit f312f67 into goetas-webservices:master Apr 29, 2019

ricoos mentioned this pull request Jan 22, 2021

xml attribute cause Uncaught ReflectionException: Class \ does not exist because it seaches empty class #129

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added symfony validator feature #2

Added symfony validator feature #2

goetas commented Oct 31, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016 •

edited

Loading

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

goetas Nov 1, 2016

goetas Nov 1, 2016

davidsonalencar Nov 1, 2016

davidsonalencar commented Nov 1, 2016

goetas commented Jan 20, 2019

goetas commented Apr 27, 2019

goetas commented Apr 27, 2019

Added symfony validator feature #2

Added symfony validator feature #2

Conversation

goetas commented Oct 31, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidsonalencar Nov 1, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidsonalencar commented Nov 1, 2016

goetas commented Jan 20, 2019

goetas commented Apr 27, 2019

goetas commented Apr 27, 2019

davidsonalencar Nov 1, 2016 •

edited

Loading