Removed empty attribute

[soukicz]

Twital is removing empty attributes which is fine for most elements except OPTION. IE9 will use option text as value if there is missing value attribute.

$twigLoader = new Goetas\Twital\TwitalLoader(new \Twig_Loader_String());
$twigLoader->addSourceAdapter('/.*/', new Goetas\Twital\SourceAdapter\HTML5Adapter());
$twig = new Twig_Environment($twigLoader);

$source = <<<EOT
<select name="my">
<option value="">XXX</option>
<option value="1">first</option>
</select>
EOT;

print_r($twig->loadTemplate($source)->render([]));

Expected output:

<select name="my">
<option value="">XXX</option>
<option value="1">first</option>
</select>
<!--  IE9 will send my=  (empty value) -->

Actual output:

<select name="my">
<option value>XXX</option>
<option value="1">first</option>
</select>
<!--  IE9 will send my=XXX -->

[soukicz]

I have created this quick patch but i don't like very much that placeholder:

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Goetas\Twital\EventDispatcher\SourceEvent;
use Goetas\Twital\EventDispatcher\TemplateEvent;

class CompatibilitySubscriber implements EventSubscriberInterface {
    const PLACEHOLDER = 'placeholderXXX###===';

    public static function getSubscribedEvents() {
        return [
            'compiler.pre_dump' => [
                ['valueAddPlaceholder']
            ],
            'compiler.post_dump' => [
                ['valueRemovePlaceholder']
            ],
        ];
    }

    public function valueAddPlaceholder(TemplateEvent $event) {
        $doc = $event->getTemplate()->getDocument();

        $xp = new \DOMXPath($doc);
        $xp->registerNamespace('xh', 'http://www.w3.org/1999/xhtml');

        /**
         * @var $option \DOMElement
         */
        foreach ($xp->query("//xh:option[@value='']") as $option) {
            $option->setAttribute('value', self::PLACEHOLDER);
        }
    }

    public function valueRemovePlaceholder(SourceEvent $event) {
        $event->setTemplate(str_replace(
                ' value="' . self::PLACEHOLDER . '"',
                ' value=""',
                $event->getTemplate())
        );
    }
}

[goetas]

It should be an https://github.com/Masterminds/html5-php issue.. i will check it

[goetas]

See Masterminds/html5-php#84, it will be fixed soon