Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved boolean attribute handling #84

Merged
merged 2 commits into from
May 17, 2015
Merged

Improved boolean attribute handling #84

merged 2 commits into from
May 17, 2015

Conversation

goetas
Copy link
Member

@goetas goetas commented May 9, 2015

This HTML code is serialized in a wrong way:

<select>
    <option value="">foo</option>
</select>

<div data-attr="">
</div>

Pre-fix result

<select>
    <option value>foo</option>
</select>

<div data-attr>
</div>

Post-fix result

<select>
     <option value="">foo</option>
</select>

<div data-attr="">
</div>

@goetas goetas added the bug label May 9, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.75%) to 89.73% when pulling 93df365 on boolean-attribiutes into 6222ad4 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.75%) to 89.73% when pulling 93df365 on boolean-attribiutes into 6222ad4 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.75%) to 89.73% when pulling e36b070 on boolean-attribiutes into 6222ad4 on master.

goetas added a commit that referenced this pull request May 17, 2015
Improved boolean attribute handling
@goetas goetas merged commit c69bde1 into master May 17, 2015
@goetas goetas deleted the boolean-attribiutes branch June 15, 2015 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants