Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): move from pnpm to bun #295

Closed

Conversation

benpsnyder
Copy link
Contributor

Work in progress (POC)
Opening for feedback

@benpsnyder
Copy link
Contributor Author

@brandonroberts could you comment on this?
image

@brandonroberts
Copy link
Contributor

Is this being imported on the server? Nitro needs to be configured to use tsconfig paths

analogjs/analog#977 (comment)

@benpsnyder
Copy link
Contributor Author

Is this being imported on the server? Nitro needs to be configured to use tsconfig paths

analogjs/analog#977 (comment)

I thought we solved that with https://github.com/goetzrobin/spartan/blob/main/apps/app/nitro.config.ts

@benpsnyder
Copy link
Contributor Author

This works if you use pnpm.
image

image

nx run-many --target=build --all

I am going to open an issue over in the Bun repo referencing this PR.

@benpsnyder
Copy link
Contributor Author

OK it works if you remove workspaces from ./package.json (you need to delete node_modules and bun i fresh)

"workspaces": [
  "apps/**",
  "libs/**",
  "tools/**"
],

I don't fully understand why.

@goetzrobin
Copy link
Owner

@benpsnyder I'll close this PR for now. Once you have the time and capacity to resolve the conflicts feel free to update and reopen!

@goetzrobin goetzrobin closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants