Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to improve Apache Parquet FSR and disapprove the duplicate #468

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

rbramley
Copy link
Contributor

Resolves #54 and #110

Copy link

Here are the changes in FSR_QC.csv:

1. issue number 1. Person name 1. ORCID 1. FSR long name 1. FSR thing 1. FSR np identifier 1. URI of duplicate(s) (multiple separated by ';') 1. Links correct 1. Proposed Links 1. Definition ok 1. FSR types ok 1. FAIRSharing DOI to be added 1. FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID 1. proposal: accept (A) / Improve (I) / Retract (R) / Disapprove (D) 1. Proposed changes: 2. actual changes: accept (A) / Improve (I) / Retract (R) / Disapprove (D) 2. URI of updated FSR 2. if FSR is useless, check affected FIPs or SIPs (title) 2. Updated (U) /Deleted (D) entry in FIP/SIP
+ 54 Robin Bramley 0000-0002-8958-8087 Apache Parquet http://purl.org/np/RAJdVVQVtRnX3vWa4ONUbZwEjX4Al59Wpy_FWduIhCrWs#Parquet http://purl.org/np/RAJdVVQVtRnX3vWa4ONUbZwEjX4Al59Wpy_FWduIhCrWs http://purl.org/np/RAO_fL9wh9zwi2hT41IftbOakQ1-wniu_KzyjmttNMhTw N Link is currently in seeAlso rather than URL Y N F D
+ 110 Robin Bramley 0000-0002-8958-8087 Apache Parquet http://purl.org/np/RAO_fL9wh9zwi2hT41IftbOakQ1-wniu_KzyjmttNMhTw#Parquet http://purl.org/np/RAO_fL9wh9zwi2hT41IftbOakQ1-wniu_KzyjmttNMhTw http://purl.org/np/RAJdVVQVtRnX3vWa4ONUbZwEjX4Al59Wpy_FWduIhCrWs N Link is currently in seeAlso rather than URL Y Y F I Fix URL

@rbramley rbramley linked an issue Jan 23, 2024 that may be closed by this pull request
Copy link
Contributor

@mabablue mabablue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@rbramley
Copy link
Contributor Author

Hi @mabablue - unfortunately I don't seem to have the necessary facilitator permissions in the FIP Wizard to be able to improve the FER or comment on it.

@mabablue
Copy link
Contributor

Hi @mabablue - unfortunately I don't seem to have the necessary facilitator permissions in the FIP Wizard to be able to improve the FER or comment on it.

you should have them now, sorry for that

Copy link

Here are the changes in FSR_QC.csv:

1. issue number 1. Person name 1. ORCID 1. FSR long name 1. FSR thing 1. FSR np identifier 1. URI of duplicate(s) (multiple separated by ';') 1. Links correct 1. Proposed Links 1. Definition ok 1. FSR types ok 1. FAIRSharing DOI to be added 1. FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID 1. proposal: accept (A) / Improve (I) / Retract (R) / Disapprove (D) 1. Proposed changes: 2. actual changes: accept (A) / Improve (I) / Retract (R) / Disapprove (D) 2. URI of updated FSR 2. if FSR is useless, check affected FIPs or SIPs (title) 2. Updated (U) /Deleted (D) entry in FIP/SIP
+ 54 Robin Bramley 0000-0002-8958-8087 Apache Parquet http://purl.org/np/RAJdVVQVtRnX3vWa4ONUbZwEjX4Al59Wpy_FWduIhCrWs#Parquet http://purl.org/np/RAJdVVQVtRnX3vWa4ONUbZwEjX4Al59Wpy_FWduIhCrWs http://purl.org/np/RAO_fL9wh9zwi2hT41IftbOakQ1-wniu_KzyjmttNMhTw N Link is currently in seeAlso rather than URL Y N F D I https://w3id.org/np/RAhHD3snWbRALC4cAdoQ3FJ8p0RoP0xcdKvNGLtwzVLcE
+ 110 Robin Bramley 0000-0002-8958-8087 Apache Parquet http://purl.org/np/RAO_fL9wh9zwi2hT41IftbOakQ1-wniu_KzyjmttNMhTw#Parquet http://purl.org/np/RAO_fL9wh9zwi2hT41IftbOakQ1-wniu_KzyjmttNMhTw http://purl.org/np/RAJdVVQVtRnX3vWa4ONUbZwEjX4Al59Wpy_FWduIhCrWs N Link is currently in seeAlso rather than URL Y Y F I Fix URL R

@rbramley
Copy link
Contributor Author

Contacted Shuai who improved the FER in FIP Wizard to remove the superfluous Semantic model type (on the FSR listed as issue 54). Consequently I have qualified that new nanopub and confirmed that it's qualification_np appears in find_gofair_qualified_things_x and the checkmark appears in the FIP Wizard.
The duplicate FSR listed as issue 110 was then retracted through the FIP Wizard. It had no references in FIPs (checked through the matrix).

@rbramley rbramley merged commit 5b20215 into main Jan 31, 2024
1 check passed
@rbramley rbramley deleted the issue_54_parquet branch January 31, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache Parquet Apache Parquet
2 participants