update otel #56
Merged
update otel #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # otelfiber/example/go.mod # otelfiber/example/go.sum # otelfiber/go.mod # otelfiber/go.sum
efectn
reviewed
Jan 13, 2022
|
@efectn not sure what to add to the readme, as we already have a minimum example code |
|
@efectn updated with 2 more fixes |
WLun001
force-pushed
the
otel-enhancement
branch
from
7b2711b
to
04bd962
Compare
efectn
approved these changes
Jan 14, 2022
|
Do you think to include metrics into the otelfiber? I think it would be great. |
|
@efectn metrics leave it for next time |
|
Good to merge? @efectn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.server_name#58EnduserIDKey