♻️ fix!: context key collisions #896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixcolors
changed the title
16 tasks
ReneWerner87
reviewed
Jan 3, 2024
|
The FromContext pattern is a lot easier to use! 👍 |
Appears that way. At least in core and contrib. 3rd party middleware were not reviewed. |
|
@ReneWerner87 I created a v3-beta branch, you can merge this into that. (PR set to merge there) |
ReneWerner87
approved these changes
Feb 10, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes context key collisions mentioned in issue gofiber/fiber#2684
related to gofiber/fiber#2781
BREAKING CHANGE
Intended for v3