Skip to content

Commit

Permalink
🧹 tidy up: fix linter errors for tests (#2102)
Browse files Browse the repository at this point in the history
  • Loading branch information
efectn committed Sep 19, 2022
1 parent 45229ed commit 305bb07
Show file tree
Hide file tree
Showing 5 changed files with 181 additions and 80 deletions.
5 changes: 3 additions & 2 deletions app_test.go
Expand Up @@ -1215,7 +1215,7 @@ func Benchmark_App_ETag_Weak(b *testing.B) {
app := New()
c := app.AcquireCtx(&fasthttp.RequestCtx{})
defer app.ReleaseCtx(c)
c.Send([]byte("Hello, World!"))
utils.AssertEqual(b, nil, c.Send([]byte("Hello, World!")))
for n := 0; n < b.N; n++ {
setETag(c, true)
}
Expand Down Expand Up @@ -1440,7 +1440,8 @@ func Test_App_New_Test_Parallel(t *testing.T) {
t.Run("Test_App_New_Test_Parallel_1", func(t *testing.T) {
t.Parallel()
app := New(Config{Immutable: true})
app.Test(httptest.NewRequest("GET", "/", nil))
_, err := app.Test(httptest.NewRequest("GET", "/", nil))
utils.AssertEqual(t, nil, err)
})
t.Run("Test_App_New_Test_Parallel_2", func(t *testing.T) {
t.Parallel()
Expand Down

1 comment on commit 305bb07

@ReneWerner87
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 305bb07 Previous: 478fe45 Ratio
Benchmark_Ctx_Protocol 22.53 ns/op 0 B/op 0 allocs/op 2.345 ns/op 0 B/op 0 allocs/op 9.61
Benchmark_EqualFoldBytes/fiber 131.4 ns/op 0 B/op 0 allocs/op 61.77 ns/op 0 B/op 0 allocs/op 2.13
Benchmark_StatusMessage/default 14.48 ns/op 0 B/op 0 allocs/op 3.682 ns/op 0 B/op 0 allocs/op 3.93

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.