Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timing attack in basicauth #1113

Merged
merged 2 commits into from
Jan 15, 2021
Merged

fix timing attack in basicauth #1113

merged 2 commits into from
Jan 15, 2021

Conversation

bestgopher
Copy link
Contributor

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?
see issue in gin

Commit formatting

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

Copy link
Contributor

@kiyonlin kiyonlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kiyonlin kiyonlin changed the title fix timing attack fix timing attack in basicauth Jan 15, 2021
@ReneWerner87 ReneWerner87 self-requested a review January 15, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants