-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π₯ adds and additional line to starting banner "bound: http://0.0.0.0:8080" #1210
Conversation
Thanks for opening this pull request! π Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
I think it would be a good idea to color-code the clickable address. Or make this notation for more understandable view:
|
I love @koddr's idea |
thanks @koddr I updated the message, yeah its way clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By the way, @kiyonlin Maybe it is better to use the // ...
switch host {
case "0.0.0.0":
// logic with 0.0.0.0
default:
// default case
} We may still have other cases and it will look better this approach (in the future). What do you think? |
I think we only have one special case |
Okay! So, LGTM now. |
Congrats on merging your first pull request! π We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
I submitted an issue #1207 saying when I bound to socket "0.0.0.0" the banner said 127.0.0.1.
i.e.
with this PR you will now see the following when host == "0.0.0.0" or ""
I'm just a newbie at go so it might be worth a review, or a rejection. I tested manually and
go test