Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Removed Printed Warning #1268

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

sagar23sj
Copy link
Contributor

@sagar23sj sagar23sj commented Apr 6, 2021

removed print statement for a warning from the monitor.go file in middleware

removed print statement for warning from monitor.go file
@sagar23sj sagar23sj closed this Apr 6, 2021
@sagar23sj sagar23sj reopened this Apr 6, 2021
@sagar23sj
Copy link
Contributor Author

Can someone help me understand what is the problem resulting in Test / Build (1.16.x, ubuntu-latest) (pull_request) Failure?.

@ReneWerner87
Copy link
Member

good questions ,i think in the test of the cache middleware there is still something not quite optimal and time dependent tested, so the test can fail in some cases, if the process takes too long

have restarted the checks, should run now

@ReneWerner87 ReneWerner87 linked an issue Apr 6, 2021 that may be closed by this pull request
@ReneWerner87
Copy link
Member

@sagar23sj please do not forget to adjust the readme of the monitoring middleware

@sagar23sj
Copy link
Contributor Author

@sagar23sj please do not forget to adjust the readme of the monitoring middleware

Hi there @ReneWerner87 , can you just check the conversation on issue #1268 . I have proposed the changes in readme.
If you can confirm them, I will raise a PR for that as well.
Thanks

@ReneWerner87
Copy link
Member

https://github.com/gofiber/fiber/blob/master/middleware/monitor/README.md
yes please, add this to the readme in the pull request

@sagar23sj
Copy link
Contributor Author

Hi @ReneWerner87 , should i push the changes in readme in this PR only or should I create a separate PR for readme fix.
Thanks

@ReneWerner87
Copy link
Member

please this PR

added warning message in monitor middleware readme
@ReneWerner87 ReneWerner87 merged commit ecfcf1c into gofiber:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Monitor Middleware - Remove fmt.Println?
2 participants