-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Removed Printed Warning #1268
♻️ Removed Printed Warning #1268
Conversation
removed print statement for warning from monitor.go file
Can someone help me understand what is the problem resulting in Test / Build (1.16.x, ubuntu-latest) (pull_request) Failure?. |
good questions ,i think in the test of the cache middleware there is still something not quite optimal and time dependent tested, so the test can fail in some cases, if the process takes too long have restarted the checks, should run now |
@sagar23sj please do not forget to adjust the readme of the monitoring middleware |
Hi there @ReneWerner87 , can you just check the conversation on issue #1268 . I have proposed the changes in readme. |
https://github.com/gofiber/fiber/blob/master/middleware/monitor/README.md |
Hi @ReneWerner87 , should i push the changes in readme in this PR only or should I create a separate PR for readme fix. |
please this PR |
added warning message in monitor middleware readme
removed print statement for a warning from the monitor.go file in middleware