Handler Errors #127
Closed
Handler Errors #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. |
golangcibot
reviewed
Feb 12, 2020
| @@ -176,7 +176,9 @@ func (app *Application) handler(fctx *fasthttp.RequestCtx) { | |||
| // Set route pointer if user wants to call .Route() | |||
| ctx.route = route | |||
| // Execute handler with context | |||
| route.Handler(ctx) | |||
| if err := route.Handler(ctx); err != nil { | |||
There was a problem hiding this comment.
SA9003: empty branch (from staticcheck)
| @@ -192,7 +194,9 @@ func (app *Application) handler(fctx *fasthttp.RequestCtx) { | |||
| if route.Midware && strings.HasPrefix(path, route.Path) { | |||
| found = true | |||
| ctx.route = route | |||
| route.Handler(ctx) | |||
| if err := route.Handler(ctx); err != nil { | |||
There was a problem hiding this comment.
SA9003: empty branch (from staticcheck)
| @@ -227,7 +231,9 @@ func (app *Application) handler(fctx *fasthttp.RequestCtx) { | |||
| ctx.route = route | |||
|
|
|||
| // Execute handler with context | |||
| route.Handler(ctx) | |||
| if err := route.Handler(ctx); err != nil { | |||
There was a problem hiding this comment.
SA9003: empty branch (from staticcheck)
|
Thanks for your PR, but we had a different API in mind see #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #126, I have added the error to the handler syntax, but it has empty logic for handling errors.