Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor: Remove use of deprecated functions #1474

Merged
merged 1 commit into from
Aug 6, 2021
Merged

♻️ Refactor: Remove use of deprecated functions #1474

merged 1 commit into from
Aug 6, 2021

Conversation

pcen
Copy link
Contributor

@pcen pcen commented Aug 5, 2021

Please provide enough information so that others can review your pull request:

Removing the use of deprecated functions GetString, GetBytes, and ImmutableString, and altering convert_test.go to test the non-deprecated equivalent conversion functions.

Explain the details for making this change. What existing problem does the pull request solve?

This change improves code quality by removing the use of deprecated functions in the framework.

Commit formatting

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@welcome
Copy link

welcome bot commented Aug 5, 2021

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@pcen pcen marked this pull request as ready for review August 6, 2021 05:35
@ReneWerner87 ReneWerner87 linked an issue Aug 6, 2021 that may be closed by this pull request
@ReneWerner87 ReneWerner87 merged commit 15987a2 into gofiber:master Aug 6, 2021
@welcome
Copy link

welcome bot commented Aug 6, 2021

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87
Copy link
Member

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated functions are used in framework code
2 participants