Revert ":sparkles: feature: add SendFileWithConfig method to ctx" #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit f19ef67.
trim21
pushed a commit
to trim21/fiber
that referenced
this pull request
Aug 15, 2022
…iber#1852)" (gofiber#1861) This reverts commit f19ef67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1852
due to errors found afterwards, the code must be removed from the master for the time being
error is that the global send file filehandler is only initialized once, but is adjusted several times by the config at runtime
-> this can cause unforeseen errors when used in parallel or in different handlers with and without config