-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added code link to fiber config fields #2385
Conversation
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Hey @shahriarsohan, thanks for providing this!
Please update the links so they don’t refer to the master branch. When we decide to update the file in the future, the line reference will no longer be correct.
Probably best to link to the latest tag instead (which pretty likely won’t change).
|
Hey @leonklingele . It seems after every change in In Future, If we specifically update Thanks |
hmm, why not link to the file without any line references? Would allow us to point to master and an always up-to-date version.
|
That also make sense because |
@leonklingele any update on this? |
@shahriarsohan it seems the API docs are autogenerated nowadays, so you need to make this change at another place (the Markdown file which you modified will get overwritten and lose your changes after the next auto docs update). Instead, do your change here: Lines 384 to 392 in e954194
And use this kind of reference style: https://github.com/fluhus/godoc-tricks/blob/4591e94c7b265f433db7aa658fa914beb532b9af/doc.go#L262 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusing, was under the impression we auto-gen the docs nowadays.
I've opened #2401 as a feature request for this.
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Description
When reading the docs , It was hard to see what Colors and DefaultColors really mean in Fiber.New() config fields. I added direct code link, now we can click that and see the code.
Type of change
Checklist: