Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README Hebrew translation #303

Merged
merged 1 commit into from Apr 25, 2020
Merged

Add README Hebrew translation #303

merged 1 commit into from Apr 25, 2020

Conversation

ofirrock
Copy link
Contributor

@ofirrock ofirrock commented Apr 25, 2020

- added README_heb.mb for hebrew translation.
- did not touch license description.
- need to add IL flag to `static/flags` folder inside https://github.com/gofiber/docs. (https://cdnjs.cloudflare.com/ajax/libs/flag-icon-css/3.4.6/flags/4x3/il.svg)
- updated number of translations in all readme files.
- vscode auto-format markdown tables in all readme files.
@welcome
Copy link

welcome bot commented Apr 25, 2020

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you want to chat with us, join ons on Telegram https://t.me/gofiber

Copy link
Member

@jozsefsallai jozsefsallai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@thomasvvugt thomasvvugt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, welcome to Fiber and many thanks for your contribution! 🎉

@Fenny
Copy link
Member

Fenny commented Apr 25, 2020

LGTM, @koddr is adding more flags to the static folder. We will merge when this is done 👍

Copy link
Contributor

@koddr koddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofirrock Nice job!

I added Israel flag to docs repo.

@Fenny Fenny merged commit 7bb2b65 into gofiber:master Apr 25, 2020
@welcome
Copy link

welcome bot commented Apr 25, 2020

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you want to chat with us, join ons on Telegram https://t.me/gofiber

@ofirrock ofirrock deleted the he-translation branch April 25, 2020 20:05
@Fenny Fenny mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants