add two statuscodes: 421,103 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you want to chat with us, join ons on Telegram https://t.me/gofiber |
auto-assign
bot
requested review from
Fenny,
jozsefsallai,
koddr and
thomasvvugt
Fenny
requested changes
Apr 26, 2020
There was a problem hiding this comment.
@bestgopher, thanks for your PR, could you also add the constants?
StatusEarlyHints = 103 https://github.com/gofiber/fiber/blob/master/utils.go#L638
StatusMisdirectedRequest = 421 https://github.com/gofiber/fiber/blob/master/utils.go#L678
|
@Fenny Yes, of course |
add two constants： StatusEarlyHints, StatusMisdirectedRequest
|
@Fenny Check it, please. |
Fenny
approved these changes
Apr 26, 2020
|
Thank you @bestgopher ! |
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you want to chat with us, join ons on Telegram https://t.me/gofiber |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 2 status codes based on golang src：
421:https://github.com/golang/go/blob/09630172d45c09e150bd1329e37b74611d4af830/src/net/http/status.go#L55
103:https://github.com/golang/go/blob/09630172d45c09e150bd1329e37b74611d4af830/src/net/http/status.go#L13