Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring, translate to Russian, add CORS middleware #4

Merged
merged 17 commits into from Feb 3, 2020
Merged

Refactoring, translate to Russian, add CORS middleware #4

merged 17 commits into from Feb 3, 2020

Conversation

koddr
Copy link
Contributor

@koddr koddr commented Feb 1, 2020 •
edited

  • Translate README to Russian lang
  • Clean logo.jpg (remove top gray line)
  • Create PNG logo with transparent background (two sizes: 320px, 750px)
  • Add dummy CORS middleware
  • Refactoring spaces and typo in comments

Also, I change names of some functions/structs (for go-lint recommendations):

  • route struct -> Route struct
  • BaseUrl -> BaseURL
  • OriginalUrl -> OriginalURL
  • Ip -> IP
  • Json -> JSON
  • Jsonp -> JSONP
  • Xml -> XML
  • JsonString -> JSONString
  • JsonBytes -> JSONBytes
  • contentTypeJson -> contentTypeJSON
  • contentTypeXml -> contentTypeXML

This is my support awesome project Fiber! 馃榾

P.S. If you can (and want), please add me to gofiber organization. I want to styling it (create and upload cute logo, description, pins, etc.), but I can't send PR to organization 馃槥

@koddr koddr requested a review from Fenny February 2, 2020 09:09
@Fenny
Copy link
Member

Fenny commented Feb 2, 2020

Thnx, I will review it later tonight 馃憤

@koddr koddr mentioned this pull request Feb 3, 2020
Closed
Fenny
Fenny reviewed Feb 3, 2020
View reviewed changes
Copy link
Member

@Fenny Fenny left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull 馃憤 , I will add a language structure to the API documentation later on.

@Fenny Fenny merged commit b7e63c4 into gofiber:master Feb 3, 2020
@Fenny Fenny mentioned this pull request Feb 3, 2020
Merged
Fenny pushed a commit that referenced this pull request Feb 8, 2020
@koddr
Merge pull request #4 from gofiber/master
f5303fd 
Accumulative update @ 08 Feb 2020
Fenny pushed a commit that referenced this pull request Feb 17, 2020
@koddr
Merge pull request #4 from gofiber/master
cbf14ef 
Accumulative update @ 16 Feb 2020
Fenny pushed a commit that referenced this pull request Mar 15, 2020
@koddr
Merge pull request #4 from gofiber/master
16a1cbe 
Accomodation update @ 15 Mar 2020
Fenny pushed a commit that referenced this pull request Oct 27, 2020
@codemicro
Merge pull request #4 from gofiber/master
8745ad7 
merge in changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fenny Fenny Fenny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koddr @Fenny