Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctx: do not use normalized path #482

Merged
merged 1 commit into from
Jun 18, 2020
Merged

ctx: do not use normalized path #482

merged 1 commit into from
Jun 18, 2020

Conversation

humaidq
Copy link
Contributor

@humaidq humaidq commented Jun 18, 2020

No description provided.

@humaidq humaidq requested a review from a team as a code owner June 18, 2020 21:15
@humaidq humaidq requested review from ReneWerner87 and jozsefsallai and removed request for a team June 18, 2020 21:15
@welcome
Copy link

welcome bot commented Jun 18, 2020

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@humaidq humaidq changed the title ctx: do not normalized path ctx: do not use normalized path Jun 18, 2020
@jozsefsallai
Copy link
Member

Hi!
As @ReneWerner87 mentioned, could you also add a test case that ensures /////admin doesn't match /admin and sends 404? Thank you so much 🙏

@Fenny Fenny merged commit 0af0dd8 into gofiber:master Jun 18, 2020
@welcome
Copy link

welcome bot commented Jun 18, 2020

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

This was referenced Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants