Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Upgrade to github.com/golang-jwt/jwt/v5 and use github.com/MicahParks/keyfunc/v2 for JWK Set client #129

Merged
merged 19 commits into from
May 19, 2023

Conversation

MicahParks
Copy link
Contributor

The purpose of this pull request is to upgrade the upstream JWT package to github.com/golang-jwt/jwt/v5 and replace the built-in JWK Set client with github.com/MicahParks/keyfunc/v2.

Both of these are breaking changes. I would prefer to target a v4-candidate or similar branch. There is an opportunity to make other breaking changes. I'm not sure if the maintainers have other breaking changes in mind.

Intended to close #128

config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@ReneWerner87
Copy link
Member

thank you , will look at it (latest by the weekend), had overlooked it

@ReneWerner87 ReneWerner87 self-requested a review May 4, 2023 14:41
go.mod Show resolved Hide resolved
config.go Show resolved Hide resolved
@gaby
Copy link
Member

gaby commented May 8, 2023

@MicahParks seems like https://github.com/golang-jwt/jwt/releases does that mean the import changes to v5?

main_test.go Show resolved Hide resolved
@ReneWerner87
Copy link
Member

are we good with the current changes ? is there anything left open ?

@MicahParks
Copy link
Contributor Author

are we good with the current changes ? is there anything left open ?

There are a few threads open tied to TODO comments in the code that I made. Changes for these TODOs is optional, but I'd like to remove the TODOs before the pull request is merged.

  1. There is this thread about a cosmetic rename.
  2. There is this thread about a user specified JWT signature algorithm for verification.
  3. There is this thread about error vs panic.

@efectn
Copy link
Member

efectn commented May 17, 2023

are we good with the current changes ? is there anything left open ?

There are a few threads open tied to TODO comments in the code that I made. Changes for these TODOs is optional, but I'd like to remove the TODOs before the pull request is merged.

  1. There is this thread about a cosmetic rename.
  2. There is this thread about a user specified JWT signature algorithm for verification.
  3. There is this thread about error vs panic.

Made some comments about TODOs

@efectn efectn requested review from ReneWerner87 and gaby May 18, 2023 20:06
@ReneWerner87 ReneWerner87 merged commit 2cb352e into gofiber:master May 19, 2023
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to support github.com/golang-jwt/jwt/v5
4 participants