feat: add proxy redirect support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Since fiber doesn't handle proxy redirects in its redirect function, I think this may help people to configure Swagger behind a proxy.
Maybe in the future fiber itself should handle it, just like what the Spring (one of the most used web frameworks in the world) do in its implementation: ForwardedHeaderTransformer.java
In this PR the proxy prefix is handled only once to match the previous implementation so it will not fix all possible problems (for example accessing the documentation from a gateway and then accessing it from a port-forward at the same time). But I think it is acceptable for now since it will fix the most common one (accessing from the gateway).