Removing margin and padding from body #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaby
approved these changes
Jan 13, 2024
gaby
changed the title
gaby
changed the title
| @@ -94,6 +94,7 @@ const indexTmpl string = ` | |||
| {{end}} | |||
|
|
|||
| window.ui = ui | |||
| document.getElementsByTagName("body")[0].style="margin:0;padding:0" | |||
There was a problem hiding this comment.
@projectxiel Why not with native style tag?
There was a problem hiding this comment.
I tried that when forking, and couldn't quit get it to work, maybe someone else can
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the change I've made there is a default margin on the body, or maybe its padding I didn't really check, the point is there is a gap between the outter edges of the browser and the outer edges of the UI.
I've noticed this for years, because this isn't the first time I've used this. Its been bugging me like crazy so I finally cracked and decided to fork just fix this one little thing, and really it takes a single line of js, or theoretically you could do it in CSS too.
With the change there is no longer the gap and people like me who get annoyed by little things like this can sleep easier at night.