Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate code of metrics in pubsub package #89

Closed
VipulSharma1999 opened this issue Nov 27, 2023 · 0 comments · Fixed by #90
Closed

Remove duplicate code of metrics in pubsub package #89

VipulSharma1999 opened this issue Nov 27, 2023 · 0 comments · Fixed by #90
Assignees
@VipulSharma1999
Labels
enhancement New feature or request

Comments

@VipulSharma1999
Copy link

VipulSharma1999 commented Nov 27, 2023 •
edited

The same set of metrics code is written in multiple places in pubsub package, instead, it can be done in a specific file and can be used from there wherever needed in pubsub package.
Thoughts?
@VipulSharma1999 VipulSharma1999 mentioned this issue Nov 27, 2023
Merged
@vipul-rawat vipul-rawat linked a pull request Nov 27, 2023 that will close this issue
Removed duplicate metrics and added in the common file #90
Merged
@vikash vikash added the enhancement New feature or request label Nov 28, 2023
@VipulSharma1999 VipulSharma1999 changed the title Remove duplicate initialisation of metrics in pubsub package Remove duplicate code of metrics in pubsub package Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VipulSharma1999 VipulSharma1999

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed duplicate metrics and added in the common file VipulSharma1999/gofr
2 participants
@vikash @VipulSharma1999