Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicate metrics and added in the common file #90

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Removed duplicate metrics and added in the common file #90

merged 7 commits into from
Nov 28, 2023

Conversation

VipulSharma1999
Copy link

@VipulSharma1999 VipulSharma1999 commented Nov 27, 2023 •
edited

  • Removed duplicate metrics from the pubsub package and added those in the common file(metrics.go).

Github issue: #89

@vipul-rawat
Copy link
Contributor

@VipulSharma1999 please check the linters, the code quality check is failing

@vipul-rawat vipul-rawat linked an issue Nov 27, 2023 that may be closed by this pull request
Remove duplicate code of metrics in pubsub package #89
Closed
@vipul-rawat vipul-rawat reopened this Nov 28, 2023
@vikash vikash merged commit 839ab54 into gofr-dev:development Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikash vikash vikash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate code of metrics in pubsub package
3 participants
@VipulSharma1999 @vipul-rawat @vikash