Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SubscribeWithCommit for google pubsub #92

Merged
merged 3 commits into from Nov 28, 2023

Conversation

stella551
Copy link

@stella551 stella551 commented Nov 27, 2023

  • Previously, SubscribeWithCommit calls Subscribe and it was able to consume only one message at a time.
  • Currently, SubscribeWithCommit will continue to consume all the messages accordingly to number of messages you want to consume.
  • SubscribeWithCommit calls the CommitFunc after subscribing message from googlePubSub and based on the return values decides whether to commit message and consume another message.

closes #88

Umang01-hash
Umang01-hash previously approved these changes Nov 28, 2023
@stella551 stella551 force-pushed the EN/google_pubsub_add_SubscribeWithCommit branch from ad140bc to 0fc10ec Compare November 28, 2023 12:07
@vikash vikash merged commit 63c2e34 into development Nov 28, 2023
9 checks passed
@vikash vikash deleted the EN/google_pubsub_add_SubscribeWithCommit branch November 28, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to subscribe messages while using Google Pubsub
5 participants