Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Equal package function #35

Closed
theckman opened this issue Jul 19, 2018 · 0 comments
Closed

Deprecate Equal package function #35

theckman opened this issue Jul 19, 2018 · 0 comments
Milestone
3.0.0

Comments

@theckman
Copy link
Member

Because two values of a UUID (array) type are directly comparable, the Equal() function is superfluous. We should add a deprecation notice to the function comment, with the intent to remove it in v3.0.0.
@theckman theckman added this to the 3.0.0 milestone Jul 19, 2018
theckman added a commit that referenced this issue Jul 19, 2018
@theckman
Deprecate the Equal package function
2f1431f 
This deprecates the `Equal` package function, in favor of consumers using the
`==` comparison operator themselves between two `UUID` values. Because the UUID
value is an array type, there is no reason for the helper function.

The intent is to remove this as part of a v2.x => v3.x release.

Fixes #35

Signed-off-by: Tim Heckman <t@heckman.io>
@theckman theckman mentioned this issue Jul 19, 2018
Merged
theckman added a commit that referenced this issue Jul 21, 2018
@theckman
Deprecate the Equal package function
da76c80 
This deprecates the `Equal` package function, in favor of consumers using the
`==` comparison operator themselves between two `UUID` values. Because the UUID
value is an array type, there is no reason for the helper function.

The intent is to remove this as part of a v2.x => v3.x release.

Fixes #35

Signed-off-by: Tim Heckman <t@heckman.io>
@bandirsen bandirsen mentioned this issue Nov 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@theckman