This repository has been archived by the owner on Jul 8, 2020. It is now read-only.
Send back a proper multiline response #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some clients asking for features will be expecting a standard multiline ftp response (according to section 4.2 in RFC949). This adds a multiline response method and rewrites the feature command to use it.
|
This should fix #27 (as well as incompatibilities with other clients). |
|
I have tested this PR and it works well on ftp command, filezilla and webbrowsers via macOS and. It works well. Thanks! But I found it failed on transmit. |
|
How can I reproduce the failure? |
|
|
Yeah, that makes sense to me. Please feel free to merge. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients asking for features will be expecting a standard multiline ftp response (according to section 4.2 in RFC949). This adds a multiline response method and rewrites the feature command to use it.