-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jds 2.0 gopi #142
base: jds-2.0
Are you sure you want to change the base?
Jds 2.0 gopi #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make PR against jds-2.0
and not master
src/components/NBtn/NBtnContent.vue
Outdated
<div class="n-button-content" :class="'nitrozenButtonClass'"> | ||
<div class="social-icon" v-if="icon"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow BEM pattern of OOCSS paradigm instead of camelCase
src/components/NInput/NInput.less
Outdated
// border-radius: 1.6rem; | ||
width: 312px; | ||
//background: @WhiteColor; | ||
font-family: @PrimaryFont; | ||
position: relative; | ||
outline: none; | ||
box-sizing: border-box; | ||
// box-sizing: border-box; | ||
font-size: 1.6rem; | ||
-webkit-appearance: none; | ||
// -webkit-appearance: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments or make it different block aside
src/components/NInput/NInput.less
Outdated
outline:none !important; | ||
border-radius: 0% !important; | ||
border-bottom: 1.5px solid #141414 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid !important
jds-2.0-input-nms