Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 added stop message #6

Merged
merged 5 commits into from May 10, 2020
Merged

#2 added stop message #6

merged 5 commits into from May 10, 2020

Conversation

muhammednagy
Copy link
Member

Changes proposed in this pull request:

  • Added stop message.

@muhammednagy muhammednagy requested a review from abahmed May 9, 2020 12:39
@abahmed
Copy link
Member

abahmed commented May 9, 2020

@muhammednagy Can you mention in message too the port that was listening to?

@abahmed
Copy link
Member

abahmed commented May 9, 2020

Fixes #2

@muhammednagy
Copy link
Member Author

Will do.

abahmed
abahmed requested changes May 10, 2020
View reviewed changes
gearbox.go Outdated Show resolved Hide resolved
gearbox.go Outdated Show resolved Hide resolved
abahmed
abahmed requested changes May 10, 2020
View reviewed changes
gearbox.go Outdated Show resolved Hide resolved
gearbox.go Show resolved Hide resolved
gearbox.go Outdated Show resolved Hide resolved
@muhammednagy muhammednagy force-pushed the feature/add-stop-message branch 2 times, most recently from 321d0c7 to 7f0fd75 Compare May 10, 2020 12:38
abahmed
abahmed reviewed May 10, 2020
View reviewed changes
Copy link
Member

@abahmed abahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ready now, but make sure about condition of address

gearbox.go Outdated Show resolved Hide resolved
@muhammednagy
Copy link
Member Author

Race detected error didn't occur locally when testing.
Will try to reproduce it locally.
Am using the same command as github.

abahmed
abahmed approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@abahmed abahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks

@abahmed abahmed merged commit 937e731 into master May 10, 2020
@abahmed abahmed deleted the feature/add-stop-message branch May 10, 2020 17:14
@abahmed abahmed added the enhancement New feature or request label May 10, 2020
@abahmed abahmed added this to In Progress in Gearbox via automation May 10, 2020
@abahmed abahmed added this to the v1 milestone May 10, 2020
@muhammednagy muhammednagy moved this from In Progress to Done in Gearbox May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abahmed abahmed abahmed approved these changes

Assignees

@abahmed abahmed

Labels
enhancement New feature or request
Projects
Gearbox
  
Done
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@muhammednagy @abahmed