Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in gf run failed with arguments passed in windows platform #2414

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Feb 3, 2023

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 79.61% // Head: 79.61% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2fc8f7f) compared to base (39fede6).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2414      +/-   ##
==========================================
- Coverage   79.61%   79.61%   -0.01%     
==========================================
  Files         598      598              
  Lines       49682    49682              
==========================================
- Hits        39554    39553       -1     
  Misses       8131     8131              
- Partials     1997     1998       +1     
Flag Coverage Δ
go-1.15-386 79.65% <ø> (+0.01%) ⬆️
go-1.15-amd64 79.62% <ø> (-0.01%) ⬇️
go-1.16-386 79.64% <ø> (+0.01%) ⬆️
go-1.16-amd64 79.65% <ø> (-0.01%) ⬇️
go-1.17-386 79.66% <ø> (+<0.01%) ⬆️
go-1.17-amd64 79.68% <ø> (+0.02%) ⬆️
go-1.18-386 79.59% <ø> (+0.02%) ⬆️
go-1.18-amd64 79.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gfsnotify/gfsnotify_watcher_loop.go 84.87% <0.00%> (-0.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn changed the title fix: windows下gf run命令行使用args参数导致无法运行 fix issue in gf run failed with arguments passed in windows platform Feb 6, 2023
@gqcn gqcn merged commit 9ba49fa into master Feb 6, 2023
@gqcn gqcn deleted the fix/issues#2383 branch February 6, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants