Protect RemoveValue from race condition #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple gouroutines are trying to remove values from the same garray. After one routine calculate the index to remove, the other one could have removed the value before the calculated index, causing the index to shift and remove the wrong element. Making both the search and remove action atomic solve this problem.
Codecov ReportBase: 79.98% // Head: 80.03% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2472 +/- ##
==========================================
+ Coverage 79.98% 80.03% +0.04%
==========================================
Files 599 596 -3
Lines 49779 49446 -333
==========================================
- Hits 39816 39573 -243
+ Misses 8006 7936 -70
+ Partials 1957 1937 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gqcn
approved these changes
Feb 23, 2023
|
@blinkbean Thanks for your contribution! it's awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple gouroutines are trying to remove values from the same garray. After one routine calculate the index to remove, the other one could have removed the value before the calculated index, causing the index to shift and remove the wrong element. Making both the search and remove action atomic solve this problem.