Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gredis maxActive config and duplicate connection bug #2479

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

qinyuguang
Copy link
Contributor

@qinyuguang qinyuguang commented Feb 26, 2023

  • maxActive没生效
  • redis adapter初始化了两次

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Base: 79.98% // Head: 79.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (895abb5) compared to base (cbbfd85).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 895abb5 differs from pull request most recent head 09d107e. Consider uploading reports for the commit 09d107e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2479   +/-   ##
=======================================
  Coverage   79.98%   79.98%           
=======================================
  Files         599      599           
  Lines       49785    49786    +1     
=======================================
+ Hits        39821    39822    +1     
  Misses       8007     8007           
  Partials     1957     1957           
Flag Coverage Δ
go-1.15-386 80.00% <100.00%> (-0.05%) ⬇️
go-1.15-amd64 79.99% <100.00%> (-0.03%) ⬇️
go-1.16-386 80.01% <100.00%> (-0.02%) ⬇️
go-1.16-amd64 80.01% <100.00%> (+0.01%) ⬆️
go-1.17-386 80.01% <100.00%> (-0.01%) ⬇️
go-1.17-amd64 80.00% <100.00%> (-0.01%) ⬇️
go-1.18-386 79.96% <100.00%> (+0.04%) ⬆️
go-1.18-amd64 79.96% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/nosql/redis/redis.go 88.88% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qinyuguang qinyuguang changed the title fix: gredis maxActive config fix: gredis maxActive config and duplicate connection bug Feb 27, 2023
@gqcn gqcn merged commit 15d88c2 into gogf:master Feb 27, 2023
@qinyuguang qinyuguang deleted the fix/gredis-config branch February 27, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants