Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve polaris register and upgrade polaris-go version v1.3.0 #2524

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

houseme
Copy link
Member

@houseme houseme commented Mar 15, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (56f5d51) 78.61% compared to head (d1b3577) 78.60%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2524      +/-   ##
==========================================
- Coverage   78.61%   78.60%   -0.01%     
==========================================
  Files         630      630              
  Lines       51388    51388              
==========================================
- Hits        40401    40396       -5     
- Misses       9001     9008       +7     
+ Partials     1986     1984       -2     
Flag Coverage Δ
go-1.15-386 78.64% <100.00%> (+<0.01%) ⬆️
go-1.15-amd64 78.63% <100.00%> (-0.03%) ⬇️
go-1.16-386 78.64% <100.00%> (+0.01%) ⬆️
go-1.16-amd64 78.64% <100.00%> (+<0.01%) ⬆️
go-1.17-386 78.64% <100.00%> (+<0.01%) ⬆️
go-1.17-amd64 78.64% <100.00%> (-0.01%) ⬇️
go-1.18-386 78.58% <100.00%> (+0.02%) ⬆️
go-1.18-amd64 78.55% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/registry/polaris/polaris.go 59.25% <ø> (ø)
contrib/registry/polaris/polaris_service.go 100.00% <ø> (ø)
contrib/registry/polaris/polaris_registrar.go 64.54% <100.00%> (-9.10%) ⬇️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@houseme houseme requested a review from gqcn March 15, 2023 06:40
@gqcn gqcn merged commit b32eb30 into master Mar 20, 2023
@gqcn gqcn deleted the feature/up-polairs-config branch March 20, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants